feat(page-cluster): resolve which blocking key to use per page#903
Merged
Merged
Conversation
Combine the independent URL-path and stylesheet blocking keys into a single grouping key per page, preferring the stylesheet signal when it is backed by enough shared pages and falling back to the URL path otherwise. Reuses computeDocumentFrequency/splitTokensByFrequency to filter out stylesheets common across most of the batch (e.g. a shared reset/font file) before hashing, so two unrelated pages that only share such a file are not wrongly merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveBlockingGroupKeys, combining the independent URL-path (derivePathGroupKey) and stylesheet (deriveStylesheetGroupKey) blocking keys added in feat(page-cluster): add URL-path and stylesheet blocking-key derivation #902 into one final grouping key per page.minCssGroupSizepages (default 2), otherwise fall back to the URL-path key.computeDocumentFrequency/splitTokensByFrequency(feat(page-cluster): add frequency-based template/content token split #901) to strip stylesheets common across most of the batch (e.g. a shared reset/font file) before hashing, so two unrelated pages that only share such a file aren't wrongly merged into one group.Test plan
yarn buildyarn lintyarn test(1180 tests passing)/code-review xhigh(6 findings, all fixed)/qa-engineerreview/product-managerreview/docreview